Switch to scikit-build-core, build wheels with bundled OpenBLAS#252
Switch to scikit-build-core, build wheels with bundled OpenBLAS#252roryyorke wants to merge 7 commits intopython-control:masterfrom
Conversation
|
this will need a version bump - 0.6.2? Will wait for review comments before pushing any changes. |
|
When distributing wheels that vendor binary dependencies, you'll need to package the dependencies' licenses as per each dependency's license terms. I think there is some standard tool to help manage this (as it has been solved for SciPy and others). |
Thanks, I'll look into this. SLICOT is also differently licensed to Slycot (MIT vs GPL), I suppose we should indicate that somewhere too. |
Correction, BSD 3-clause: https://github.com/SLICOT/SLICOT-Reference?tab=BSD-3-Clause-1-ov-file#readme |
I had already changed this to use If we use this, I'll add Git archivesI did a test build from a Do we need to support building from a git archive like this? Is it OK to require a build be either from the sdist or from a git working tree? The .tar.gz / .zip files Github generates on release are |
Fixed in 16e02d4
I added some code to the wheel building prep script to sort this out, I didn't go looking for a tool. I have also changed the "license" field in pyproject.toml to account for all the dependencies, though I see other projects, e.g., scipy-openblas64, don't do that: the license field seems to only refer to the project's "own" code. scipy-openblas64 does include license files for all bundled dependencies. |
Fixes gh-164